Skip to content

Minor Python bugfixes and type issues#7965

Merged
CouleeApps merged 9 commits intoVector35:devfrom
nullableVoidPtr:nullableVoidPtr-bugfix
Feb 26, 2026
Merged

Minor Python bugfixes and type issues#7965
CouleeApps merged 9 commits intoVector35:devfrom
nullableVoidPtr:nullableVoidPtr-bugfix

Conversation

@nullableVoidPtr
Copy link
Contributor

@nullableVoidPtr nullableVoidPtr commented Feb 13, 2026

  • Fixed parameters for get_incoming_flag_value
  • Disambiguated return type for TypedDataAccessor.__getitem__ (previously TypedDataAcccessor | List[TypedDataAccessor] no matter the type for key)
  • Fixed parameter type conflicts in types, primarily in TypeBuilders
  • Disambiguated return type for data/text/line searchers in a BinaryView
  • Specify callback type and convert match callback param for BinaryView.find_all_text
  • Allow user-specified joins for a Python QualifiedName
  • Fix narrowed sequence elements passed into some functions causing a type mismatch
    • List is invariant, but Sequence is covariant

@nullableVoidPtr
Copy link
Contributor Author

For additional context, these are issues I came across polishing my plugin

@nullableVoidPtr
Copy link
Contributor Author

That being said, I feel like a TypeProtocol would be rather useful for easier typing when Type or TypeBuilder can be used - though I have not tested this.

@CouleeApps
Copy link
Member

These are good improvements! I only saw the following that needed changing:

  • The separator to QualifiedName is internally called join
  • Need to construct QualifiedName with join from the core struct
  • Also need to handle NameSpace type too
  • Using Self for types is a Python 3.11 feature, which exceeds our minimum supported Python of 3.9

Given these are all pretty trivial changes, I just added them onto your PR. Thanks for the contribution!

@CouleeApps CouleeApps force-pushed the nullableVoidPtr-bugfix branch from 6e70266 to 7307548 Compare February 26, 2026 18:47
@CouleeApps CouleeApps force-pushed the nullableVoidPtr-bugfix branch from 7307548 to 5999964 Compare February 26, 2026 18:48
@CouleeApps CouleeApps merged commit 5999964 into Vector35:dev Feb 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants